Skip to content

[AL-6740] assert adv global key errors separately #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2023
Merged

[AL-6740] assert adv global key errors separately #1215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 23 additions & 14 deletions tests/integration/test_global_keys.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,8 @@ def test_long_global_key_validation(client, dataset, image_url):
'error'] == 'Invalid assignment. Either DataRow does not exist, or globalKey is invalid'


def test_global_key_with_whitespaces_validation(client, dataset, image_url):
def test_global_key_with_whitespaces_validation(client, dataset, image_url,
is_adv_enabled):
dr_1 = dataset.create_data_row(row_data=image_url)
dr_2 = dataset.create_data_row(row_data=image_url)
dr_3 = dataset.create_data_row(row_data=image_url)
Expand All @@ -137,19 +138,27 @@ def test_global_key_with_whitespaces_validation(client, dataset, image_url):
}]
res = client.assign_global_keys_to_data_rows(assignment_inputs)

assert len(res['results']) == 0
assert len(res['errors']) == 3
assert res['status'] == 'FAILURE'
assign_errors_ids = set([e['data_row_id'] for e in res['errors']])
assign_errors_gks = set([e['global_key'] for e in res['errors']])
assign_errors_msgs = set([e['error'] for e in res['errors']])
assert assign_errors_ids == set([dr_1.uid, dr_2.uid, dr_3.uid])
assert assign_errors_gks == set([gk_1, gk_2, gk_3])
assert assign_errors_msgs == set([
'Invalid assignment. Either DataRow does not exist, or globalKey is invalid',
'Invalid assignment. Either DataRow does not exist, or globalKey is invalid',
'Invalid assignment. Either DataRow does not exist, or globalKey is invalid'
])
if is_adv_enabled:
assert res['status'] == 'PARTIAL SUCCESS'
assert len(res['results']) == 2
assert len(res['errors']) == 1
Copy link
Contributor

@vbrodsky vbrodsky Aug 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious why adv has 1 error vs 'legacy' 3

Copy link
Contributor Author

@attila-papai attila-papai Aug 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

due to a different global key sanitization logic implemented in ADV, but this PR is only to make the test green to enable UAT
in a follow up PR we will adjust the sanitization logic in ADV and alter these tests once again

assert res['errors'][0]['global_key'] == gk_3
assert res['errors'][0][
'error'] == "Invalid assignment. Either DataRow does not exist, or globalKey is invalid"
else:
assert len(res['results']) == 0
assert len(res['errors']) == 3
assert res['status'] == 'FAILURE'
assign_errors_ids = set([e['data_row_id'] for e in res['errors']])
assign_errors_gks = set([e['global_key'] for e in res['errors']])
assign_errors_msgs = set([e['error'] for e in res['errors']])
assert assign_errors_ids == set([dr_1.uid, dr_2.uid, dr_3.uid])
assert assign_errors_gks == set([gk_1, gk_2, gk_3])
assert assign_errors_msgs == set([
'Invalid assignment. Either DataRow does not exist, or globalKey is invalid',
'Invalid assignment. Either DataRow does not exist, or globalKey is invalid',
'Invalid assignment. Either DataRow does not exist, or globalKey is invalid'
])


def test_get_data_row_ids_for_global_keys(client, dataset, image_url):
Expand Down