Vb/bulk delete metadata by gk sdk 416 #1348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrodsky
force-pushed
the
VB/bulk-delete-metadata-by-gk_SDK-416
branch
2 times, most recently
from
9923e04 to
5bd1033
Compare
labelbox/schema/data_row_metadata.py
Outdated
| fields: List[SchemaId] | ||
|
|
||
|
|
||
| class DeleteDataRowMetadataV2(_CamelCaseMixin): |
Contributor
There was a problem hiding this comment.
Is there a way to reuse the existing DeleteDataRowMetadata by adding the new field as an optional argument without creating DeleteDataRowMetadataV2? (i am unsure if this was already discussed and finalized to do it this way).
yamini-labelbox
approved these changes
Jan 4, 2024
Contributor
yamini-labelbox
left a comment
yamini-labelbox
left a comment
There was a problem hiding this comment.
LGTM! Approved.
Added a minor comment
labelbox/schema/data_row_metadata.py
Outdated
|
|
||
| class _DeleteBatchDataRowMetadata(_CamelCaseMixin): | ||
| data_row_id: str | ||
| class _DeleteBatchDataRowMetadataV2(_CamelCaseMixin): |
Contributor
There was a problem hiding this comment.
nit: I do not see any benefit of updating the name of this method to _DeleteBatchDataRowMetadataV2. It is a minor comment though, as this is not exposed to the user. Looks good to me otherwise! Thanks for the refactor.
vbrodsky
force-pushed
the
VB/bulk-delete-metadata-by-gk_SDK-416
branch
from
fefeaad to
13f2ef9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://labelbox.atlassian.net/browse/SDK-416
Corresponding API PR: https://github.com/Labelbox/intelligence/pull/18718
This Pull Request introduces the functionality to use global keys as a parameter for bulk metadata deletion, utilizing our UniqueId/GlobalKey approach.
To support backward compatibility we:
DeleteDataRowMetadataV2input type while keeping support for existingDeleteDataRowMetadatawhich will be deprecated in the future