[SDK-507] Add method to CatalogSlice to get data row identifiers (both uids and global keys) #1357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrodsky
force-pushed
the
VB/catalog-slice-export-gk
branch
from
23cd6cd to
c0c7160
Compare
kopreschko
reviewed
Jan 8, 2024
… global keys) Also: Make return typed Add deprecation warning to get_data_row_ids
vbrodsky
force-pushed
the
VB/catalog-slice-export-gk
branch
from
c0c7160 to
5626b4e
Compare
kopreschko
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://labelbox.atlassian.net/browse/SDK-507
API PR: https://github.com/Labelbox/intelligence/pull/18762
Added a new method to get CatalogSlice data rowids AND global keys
NOTE: sdk integration tests are not possible, since we can not create a CatalogSlice via the sdk (see, more example, a slack discussion here for more info https://labelbox.slack.com/archives/C06D281RFT3/p1704495848657209)