annotation import #163
annotation import #163
Conversation
…into ms/annotation-import
…into ms/annotation-import
awu-labelbox
left a comment
awu-labelbox
left a comment
There was a problem hiding this comment.
Lgtm, I only saw non-functionality related comments
| data = json.dumps({ | ||
| 'query': query, | ||
| 'variables': params | ||
| }).encode('utf-8') |
There was a problem hiding this comment.
If params is None, would it set the value of variables to undefined? Is that OK here?
There was a problem hiding this comment.
Yeah this should be fine. Here is a minimal example you can try that works without setting params.
from labelbox import Client
client = Client()
client.execute(""" query { organization {id} }""")
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class AnnotationImport(DbObject): |
There was a problem hiding this comment.
nice! glad this name made its way into the SDK, also.
labelbox/schema/annotation_import.py
Outdated
|
|
||
| @classmethod | ||
| def _build_import_predictions_query(cls, file_args: str, vars: str): | ||
| query_str = """mutation testPredictionImportsPyApi($parent_id : ID!, $name: String!, $predictionType : PredictionType!, %s) { |
There was a problem hiding this comment.
should this be called testPredictionImportsPyPyi still? Maybe ModelErrorAnalysisPredictionImport?
labelbox/schema/annotation_import.py
Outdated
| %s : $parent_id | ||
| name: $name | ||
| %s |
There was a problem hiding this comment.
I feel like its not a big deal, but i think these could be indented (and below)
| return cls._create_from_objects(client, model_run_id, name, predictions) | ||
|
|
||
|
|
||
| class MALPredictionImport(AnnotationImport): |
There was a problem hiding this comment.
Im curious why we need this? I dont think were going to be allowing MAL imports via SDK through this mutation for a little while.
labelbox/schema/enums.py
Outdated
| class BulkImportRequestState(Enum): | ||
| """ State of the import job when importing annotations (RUNNING, FAILED, or FINISHED). | ||
| This object is deprecated. Please use PredictionImportState instead. |
There was a problem hiding this comment.
I think you mean AnnotationImportState.
| FINISHED = "FINISHED" | ||
|
|
||
|
|
||
| class ImportType(Enum): |
There was a problem hiding this comment.
I wish I'd called this variable ImportType rather than prediction type everywhere :(
No description provided.