[AL-2496] [AL-2498] Rename custom_metadata to metadata_fields for DataRow #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkim-labelbox
changed the title
nmaswood
approved these changes
May 20, 2022
nmaswood
left a comment
nmaswood
left a comment
There was a problem hiding this comment.
LGTM
In the future I would recommend breaking things like:
- renaming
- adding fields
items
into separate PRs because we can discuss and review them as separate line items
| """ | ||
| invalid_argument_error = "Argument to create_data_row() must be either a dictionary, or kwargs containing `row_data` at minimum" | ||
|
|
||
| def convert_field_keys(items): |
There was a problem hiding this comment.
I maybe move this out of the function scope and into module scope because this seems like a more general utility function type thing and doesn't need to be re-defined every time this method is called
|
|
||
| DataRow = Entity.DataRow | ||
| if DataRow.row_data.name not in kwargs: | ||
| args = convert_field_keys(items) if items is not None else kwargs |
| for key, value in items.items() | ||
| } | ||
|
|
||
| if items is not None and len(kwargs) > 0: |
There was a problem hiding this comment.
if items is maybe more concise and strict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes two changes:
AL-2496: Rename custom_metadata to metadata_fields
AL-2498: allows
create_data_rowto take in a dictionary, as well as kwargsRelated API change - https://github.com/Labelbox/intelligence/pull/8623