Skip to content

Conversation

@jtsodapop
Copy link
Contributor

8/3/2022 - Using IMG_URL=picsum... is giving an error invalid magic bytes for file

This is circumvented by using alternative websites. This PR is to use an alternative lorem image generator.

@jtsodapop
Copy link
Contributor Author

These tests will still fail on test_benchmark due to some other test issues but should pass test_create_batch which is where they were originally failing that brought up this problem (the first test that would use tests/integration which would cause conftest.py to generate a dataset fixture)

Copy link
Contributor

@kkim-labelbox kkim-labelbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! i'll approve once you remove the print statement

project.create_label = create_label
project.create_label()
label = next(project.labels())
print(f"this is a label: \n{label}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this

hydak pushed a commit that referenced this pull request Aug 5, 2022
@hydak hydak merged commit 46449e3 into develop Aug 5, 2022
@jtsodapop jtsodapop deleted the jtso/picsum_fix branch September 14, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants