[AL-0] Fix image_url fixture to use jpeg when uploading data #659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
image_urlpytest fixture, we were uploading an image with json content type and filename viaclient.upload_data, which is pretty illegal, and now being caught by the updates in the client file upload validation in the backend that @jakub-borowski introduced. This was causing the original picsum url to not work. We then attempted to useplaceholderas an alternative to picsum, but that website seems to be a bit more unreliable. Reverting back to picsum, and setting the content type and filename properly inimage_urlfixture fixes the issue