[PTDT-1107] Implemented is_feature_schema_archived client function #927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgluszek
reviewed
Mar 2, 2023
lgluszek
reviewed
Mar 2, 2023
labelbox/client.py
Outdated
| bool | ||
| """ | ||
|
|
||
| ontology_endpoint = self.rest_endpoint + "/ontologies/" + ontology_id |
Contributor
There was a problem hiding this comment.
please encode ontology_id using urllib.parse.quote
lgluszek
reviewed
Mar 2, 2023
labelbox/client.py
Outdated
| ontology_endpoint = self.rest_endpoint + "/ontologies/" + ontology_id | ||
| response = requests.get( | ||
| ontology_endpoint, | ||
| headers=self.rest_endpoint_headers, |
Contributor
There was a problem hiding this comment.
Suggested change
| headers=self.rest_endpoint_headers, | |
| headers=self.headers, |
lgluszek
reviewed
Mar 2, 2023
labelbox/client.py
Outdated
| headers=self.rest_endpoint_headers, | ||
| ) | ||
|
|
||
| if response.status_code == 200: |
Contributor
There was a problem hiding this comment.
Suggested change
| if response.status_code == 200: | |
| if response.status_code == requests.codes.ok: |
Contributor
kkim-labelbox
left a comment
kkim-labelbox
left a comment
There was a problem hiding this comment.
Left one comment, and please add a test case for the function, thanks!
labelbox/client.py
Outdated
| relationships = feature_schema_nodes['relationships'] | ||
| feature_schema_node_list = tools + classifications + relationships | ||
|
|
||
| is_feature = lambda f: f['featureSchemaId'] == feature_schema_id |
Contributor
There was a problem hiding this comment.
This can be simplified to:
filtered_feature_schema_nodes = [feature_schema_node for feature_schema_node in feature_schema_node_list if feature_schema_node['featureSchemaId'] == feature_schema_id]
if filtered_feature_schema_nodes:
return bool(filtered_feature_schema_nodes[0]['archived']
kkim-labelbox
suggested changes
Mar 8, 2023
Contributor
kkim-labelbox
left a comment
kkim-labelbox
left a comment
There was a problem hiding this comment.
Actually sorry, could you also add a case where is_feature_schema_archived is True?
kkim-labelbox
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Requires PTDT-1107 to be merged first before this can be tested.
is_feature_schema_archived(feature_schema_node_id: str, ontology_id: str)0if the specified feature schema is not archived1if the specified feature schema is archvedHow to test:
Tool 1 - Bounding Box
Tool 2 - Bounding Box
SDK Test Code
Verify that the function returns
1for archived nodes, and0otherwise.https://www.loom.com/share/643245cb1bd441ccb64f5e0c44be8995