Fix QR code regression and backend memory leak#399
Conversation
- Fixed a syntax error and unsafe dictionary merging in `whatsfly/whatsapp.py` that prevented the QR code from displaying. - Fixed a type assertion crash and a critical memory leak in `backend/clientAbstract.go`'s message loop. - Added a new unit test `tests/test_handle_message.py` to verify event processing logic. Co-authored-by: Labfox <108928065+Labfox@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Labfox
deleted the
fix/regression-qr-code-and-memory-leak-7367341398810894539
branch
1 participant
This PR fixes several regressions that made the library unusable:
whatsfly/whatsapp.py, I fixed a typo**message ** message["content"]which was both invalid Python syntax and logically incorrect for non-dictionary content (like the QR code). It now safely merges only dictionary content.backend/clientAbstract.go, I fixed a type assertion fromstringto[]byteand resolved a memory leak by movingC.freeout of adeferinside the message thread loop.tests/test_handle_message.pyto ensure robust event handling.The backend was successfully built with
go build -buildmode=c-shared, and the Python fixes were verified with the new unit test.PR created automatically by Jules for task 7367341398810894539 started by @Labfox