[Backend] Wire createStreamSchema validation into POST /v1/streams

[ogazboiz]

Join the discussion on Telegram

Why this matters

The POST /v1/streams controller (createStream in backend/src/controllers/stream.controller.ts) destructures req.body directly and passes the values straight into prisma.stream.upsert with no validation. A createStreamSchema already exists in backend/src/validators/stream.validator.ts but is never imported or used anywhere. As a result, the endpoint will:

• throw an unhandled error and return 500 when depositedAmount/ratePerSecond are missing or non-numeric (BigInt(undefined) / parseInt(NaN)),
• divide by zero in endTime computation when ratePerSecond is "0",
• accept malformed Stellar addresses for sender/recipient.

Wiring the existing validator gives clean 400 responses and removes the dead code.

Acceptance criteria

• Validate the request body with createStreamSchema (or zod safeParse) at the top of createStream and return 400 with error.issues on failure.
• Validate sender/recipient are valid Stellar public keys (a Stellar address validator already exists in the stream validators per issue Add input validation for Stellar addresses in stream endpoints #379).
• Guard ratePerSecond === '0' before the endTime division.
• Add an integration test covering a missing-field body returning 400 (extend backend/tests/integration/streams.test.ts).

Files to touch

• backend/src/controllers/stream.controller.ts
• backend/src/validators/stream.validator.ts
• backend/tests/integration/streams.test.ts

Out of scope

• Changing the on-chain create flow (this endpoint only registers/mirrors metadata).

[dannyy2000]

@dannyy2000 has applied to work on this issue as part of the Stellar Wave Program's 5th wave.

Hi maintainer, can i work on this

ℹ️ Repo Maintainers: To accept this application, review their application or assign @dannyy2000 to this issue.

[Ajibose]

@Ajibose has applied to work on this issue as part of the Stellar Wave Program's 5th wave.

I would like to work on this

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Ajibose to this issue.

[drips-wave]

Congratulations, @dannyy2000! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on June 2, 2026.

🧑‍💻 @dannyy2000: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[drips-wave]

This issue has been completed by @dannyy2000 as part of the Stellar Wave Program's 5th Wave 🥳

😎 @dannyy2000: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.