Skip to content

[Infra] Codecov upload step fails CI when CODECOV_TOKEN is missing (fail_ci_if_error: true) #528

@ogazboiz

Description

@ogazboiz

Join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0

Why this matters

Both the Backend CI and Soroban Contracts CI jobs run a final codecov/codecov-action@v5 step with fail_ci_if_error: true. When CODECOV_TOKEN is missing/invalid (as it currently is), that step fails and turns the whole job red even when build, tests, and coverage all passed. Right now the contracts job gets all the way through build + 95 tests + tarpaulin coverage and only dies on this upload.

Acceptance criteria

  • CI no longer fails solely because of Codecov upload. Either:
    • set CODECOV_TOKEN as a repo secret and confirm upload succeeds, OR
    • set fail_ci_if_error: false on both Codecov steps so coverage upload is best-effort
  • Contracts job is green when build + tests + coverage pass
  • Backend job's pass/fail reflects tests, not the upload

Files to touch

  • .github/workflows/ci.yml (the two Upload * coverage to Codecov steps)

Out of scope

  • Fixing the backend test failures themselves (separate issue)

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programbugSomething isn't workinginfraCI/CD and infrastructure

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions