Skip to content

[Backend] tsconfig.json — enable commented-out noImplicitReturns / noUnusedLocals / noUnusedParameters #652

@ogazboiz

Description

@ogazboiz

Join the discussion on Telegram

Why this matters

backend/tsconfig.json lists several stricter checks but has them commented out:

// "noImplicitReturns": true,
// "noImplicitOverride": true,
// "noUnusedLocals": true,
// "noUnusedParameters": true,
// "noFallthroughCasesInSwitch": true,
// "noPropertyAccessFromIndexSignature": true,

The team clearly considered them. Enabling at least noImplicitReturns, noUnusedLocals, and noFallthroughCasesInSwitch is cheap and would catch real backend regressions (e.g. controller paths that don't return, dead vars in claimable.service.ts already partially flagged by #547).

Acceptance criteria

  • Uncomment noImplicitReturns, noUnusedLocals, noFallthroughCasesInSwitch
  • Resolve compile errors the checker surfaces (annotate _var for params we genuinely don't want, or delete dead code)
  • npm run build and npm test pass

Optional in the same PR (or follow-up):

  • noUnusedParameters
  • noPropertyAccessFromIndexSignature

Files to touch

  • backend/tsconfig.json

Out of scope

  • Frontend tsconfig (separate issue)

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programbackendBackend related tasksgood first issueGood for newcomersrefactorRefactoring existing code

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions