Modify CI workflow for dependency installation#214
Modify CI workflow for dependency installation#214mubking wants to merge 1 commit intoLabsCrypt:mainfrom
Conversation
Updated CI workflow to use 'npm install' instead of 'npm ci' for both frontend and backend. Removed caching steps and added a newline at the end of the file.
ogazboiz
left a comment
There was a problem hiding this comment.
hey @mubking, thanks for looking into the CI issues!
the original error happened because the runner couldn't find the package-lock.json files at the specified paths. changing npm ci to npm install and removing caching isn't the ideal fix, as npm ci ensures a clean, deterministic build and caching heavily speeds up our pipelines.
could you revert the npm install change and instead ensure the cache-dependency-path correctly points to where our lockfiles actually live (either in frontend/package-lock.json or the root package-lock.json depending on your setup)?
let me know if you need help with it! if you want to contribute more or follow up if issues are open, join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0
|
hey @mubking, just checking in on this — left some feedback about 4 weeks ago but haven't heard back. quick reminder: this PR (and #212, #213, #215) all try to fix the same CI issue. rather than multiple PRs with the wrong fix (pointing
let us know if you need help, or feel free to close these and open a fresh PR once you have the right fix. and join us on Telegram anytime: https://t.me/+DOylgFv1jyJlNzM0 |
Updated CI workflow to use 'npm install' instead of 'npm ci' for both frontend and backend. Removed caching steps and added a newline at the end of the file.
Description
Type of Change
Related Issues
Closes #
Changes Made
Testing
Test Coverage
Test Steps
Breaking Changes
Breaking Changes:
Migration Guide:
Screenshots/Demo
Checklist
Additional Notes