fix: stream validation and test coverage#392
Merged
ogazboiz merged 2 commits intoApr 28, 2026
Merged
Conversation
Include FEE_COLLECTED in the list of valid event types for the stream events endpoint pagination and filtering feature. Refs LabsCrypt#364
Add 5 new test cases covering pause/resume edge cases: - Cancel while paused keeps stream inactive - Top-up while paused increases deposited amount - Withdraw after long stream runtime is bounded - Withdraw then resume stream state preservation - Multiple pause/resume cycles preserve stream active state Add fuzz tests covering financial invariants: - Withdrawn amount never exceeds deposited - Claimable amount never exceeds remaining balance - Cancel early refunds correctly - Pause/resume cycles maintain active state - Large amounts don't overflow claimable calculation All tests pass with 78/78 passing. Refs LabsCrypt#365 Refs LabsCrypt#367
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses 4 stream-related issues: event filtering, test coverage, and financial invariants.
Changes
#364 - Stream Events Endpoint
FEE_COLLECTEDto valid event types in stream events filter#365 - Pause/Resume Edge Cases
#366 - Overflow Protection
checked_mulwith saturation)saturatingMulI128to clamp values at i128 limits#367 - Fuzz Tests
Testing
Closes #364
Closes #365
Closes #366
Closes #367