closes #421

[dubemoyibe-star]

Description

Type of Change

• 🐛 Bug fix (non-breaking change which fixes an issue)
• ✨ New feature (non-breaking change which adds functionality)
• 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
• 📚 Documentation update
• 🔧 Refactoring (no functional changes)
• ⚡ Performance improvement
• 🧪 Test addition or update

Related Issues

Closes #421

Changes Made

Testing

Test Coverage

• Unit tests added/updated
• Integration tests added/updated
• Manual testing performed

Test Steps

Breaking Changes

Breaking Changes:

Migration Guide:

Screenshots/Demo

Checklist

• My code follows the project's style guidelines
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published
• I have checked for breaking changes and documented them if applicable

Additional Notes

[dubemoyibe-star]

@ogazboiz please review

[ogazboiz]

hey, main was failing CI from broken auth imports + frontend parse errors. fixed and pushed to main now. please rebase to pick up the fixes:

git fetch upstream
git rebase upstream/main
git push --force-with-lease

if there's a conflict, resolve it locally and we'll review once CI is green.

[dubemoyibe-star]

ok im on it

[dubemoyibe-star]

@ogazboiz CI failure fixed

[ogazboiz]

hey @dubemoyibe-star, the contract change looks great — stream_count is exactly what #421 needed and the test covers the cases well.

a few unrelated changes need to be removed before this can merge:

1. backend/src/controllers/stream/cancel.ts — has weird formatting (mixed indentation) and treats req.params.streamId as if it could be an array, but Express params are always strings. this change is incorrect and out of scope. please remove.

2. backend/src/services/sorobanService.ts — adds .build() to assembleTransaction. could be a real fix but it's out of scope for this PR. either drop it or split into a separate PR.

3. backend/src/types/auth.types.ts — making id optional reduces type safety unnecessarily. please remove unless there's a specific reason.

once the diff is just contracts/stream_contract/src/lib.rs + test.rs (the core feature), this is good to merge.

[dubemoyibe-star]

@ogazboiz Chief
If I make all these changes
your CI is gonna end up failing
Is that fine by you ?

[ogazboiz]

hey @dubemoyibe-star, glad CI passes now, but the scope feedback hasn't been addressed:

1. backend/src/controllers/stream/cancel.ts is still in the diff with:

   • mixed indentation (2-space and 4-space mixed in the same block — see the new lines)
   • Array.isArray(rawStreamId) treating Express params as an array, which they never are
   • duplicate "Missing streamId parameter" check (line repeated twice)
   • extra blank lines

2. backend/src/services/sorobanService.ts and backend/src/types/auth.types.ts are still in the diff, neither related to issue [Contracts] Add stream_count view function #421.

CI passing is not the same as PR being ready. issue #421 only asked for stream_count — the contracts changes are clean and ready, but the backend changes need to come out before this can merge.

please run:

git checkout origin/main -- backend/src/controllers/stream/cancel.ts backend/src/services/sorobanService.ts backend/src/types/auth.types.ts
git commit -am "chore: remove unrelated backend changes"
git push

once the diff is just the two contracts/ files and the test, this is good to merge.