fix: accessibility improvements, health endpoint, zero-rate guard, and architecture docs#468
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #465 - Add aria-label, aria-pressed, aria-expanded, and role attributes to icon-only
and custom toggle controls across settings, NotificationDropdown, IncomingStreamCard, and ModeToggle
so screen-reader and keyboard users can identify and operate every interactive surface.
closes #466 - Add "Event Indexing & Real-Time Updates" section to ARCHITECTURE.md with a data-flow
diagram, dedup constraint, IndexerState cursor, stale-read RPC fallback, action signing model table,
and a required env/secrets reference; also fix a duplicate H1 and malformed mermaid block.
closes #463 - Fix /health returning 503 when STREAM_CONTRACT_ID is unset or the indexer has no
state row yet (cold start); 503 now only fires when the indexer is enabled and its state row is
stale (lag > 60 s); add health.test.ts covering the DB-down and indexer-disabled scenarios.
closes #464 - Add StreamError::InvalidRate (code 11) and reject create_stream when
net_amount / duration rounds to zero, protecting users from accidentally locking tokens in a
stream that never accrues; update test_create_stream_zero_rate to assert the rejection and add
a boundary test confirming rate == 1 still succeeds.