Fix/issues 509 512 514 517#529
Merged
Merged
Conversation
…ssible label - Remove console.log/console.error from useStreamEvents hook - Remove unused 'users' query parameter from SSE subscription URL - Remove debug logging from reconnect retry logic - Add aria-label to top-up amount input for accessibility (fixes LabsCrypt#509, LabsCrypt#512)
- Delete unused Dashboard.tsx which contained hardcoded mock data - The live dashboard is implemented in app/dashboard/page.tsx (fixes LabsCrypt#514)
- Accept optional 1-based page query parameter in getStreamEvents - Map page to offset = (page - 1) * limit when offset is not provided - Maintain backward compatibility with existing offset/cursor parameters (fixes LabsCrypt#517)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix frontend debug logging, accessibility, dead code, and backend pagination
Summary
This PR addresses four issues spanning frontend UX improvements and backend API consistency:
usersquery parameter that the backend ignorespageparameter support to the stream events endpoint for consistent paginationFixes
Closes #509
Closes #512
Closes #514
Closes #517
Changes
Frontend
Issue #509: Remove debug console logging and unused users param
console.log('SSE connected:', data.clientId)from useStreamEvents hook onmessage handlerconsole.error()calls from SSE message parsingconsole.log()call from reconnect retry logicusersquery parameter appended to SSE subscription URLIssue #512: Add accessible label to top-up input
aria-label="Top-up amount"to the number input field on stream detail pageIssue #514: Remove dead Dashboard component
frontend/src/components/Dashboard.tsxwhich contained hardcoded mock stream dataapp/dashboard/page.tsx)Backend
Issue #517: Add page parameter support
getStreamEventscontroller to accept optionalpagequery parameteroffset = (page - 1) * limitoffsetandcursorare not provided/v1/eventsendpointTest Plan
cd frontend && npm run buildcd backend && npm run buildcd frontend && npm run lintcd backend && npm run test/v1/streams/123/events?page=2&limit=10Architecture Notes
usersparameter reduces noise in URL constructionBranch
fix/issues-509-512-514-517