Fix/inactive streams#987
Closed
TheShnider wants to merge 3 commits into
Closed
Conversation
Contributor
|
closing as superseded by #970. you both edited the exact same auth-jwt signature-tamper line (you flip a middle character, #970 replaces the whole signature with an invalid string) and they conflict, so only one can land. #970 is the larger sorobanService change and already makes that test's signature reliably invalid. your middle-char approach was the more surgical one though, good catch on the weak last-char tamper. thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #812