Conversation
useSSE.ts — a React hook, purely client-side setInterval polling fallback — browser JavaScript LabsCrypt#577
ogazboiz
left a comment
There was a problem hiding this comment.
hey @onyillto, there are some good changes here but this PR bundles 4 unrelated things together which makes it hard to review and increases risk:
- backend: env validation test safety (throws instead of process.exit in test env)
- frontend: WalletProvider signTransaction implementation
- frontend: useSSE polling fallback
- frontend: package-lock.json change (stray file)
could you split these into separate PRs? each one is a focused improvement and would be easier to review and merge individually.
also, the package-lock.json change (marking a package as dev-only) seems unrelated to everything else. please drop that from any re-submission.
let me know if you have questions!
|
The codebase issues on main have been resolved and all CI checks are passing now. Please rebase your branch to pull in the latest changes before continuing. Thanks for your patience. |
ogazboiz
left a comment
There was a problem hiding this comment.
This should be closed. The appended code uses ink!/Substrate macros (#[ink(storage)], scale::Encode) but the existing contract is Soroban. These are completely different blockchain frameworks and incompatible. Branch name fix_branch is also generic.
|
Just following up on this. The code in this PR uses ink!/Substrate framework macros but the project uses Soroban. These are incompatible frameworks. I'd recommend closing this PR and opening a new one that integrates with the existing Soroban contract structure instead. |
|
heads up, a few important changes just landed on main that affect your PR:
please rebase on latest main: git fetch upstream
git rebase upstream/main
git push --force-with-lease |
No description provided.