Conversation
|
The cli should belong to an implementaion repo 🤔 in our case ladybug. We can always reference the ladybug impl here |
Collaborator
Author
|
It hurts the argument that icebug-format is graph database agnostic. Right now it's all duckdb, which is much better at sorting a 1B edge graph than ladybug is. DuckLake tries to do this by having postgres/mysql compatible schema and by using a ducklake extension. Having all of this code in an extension vs ladybug core repo is something to look into. |
Collaborator
Author
|
The spec should definitely live in another repo such as icebug-format. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should enable implementations that don't require DuckDB.