fix undirected graphs handling#6
Conversation
16f35e3 to
fe7cb86
Compare
|
The changes look good to me. Since the code touches some of the perf sensitive duckdb queries, suggest testing a large graph such as livejournal or wikidata to ensure that there are no regressions. I recall wikidata needing at least 32GB of RAM to process. |
|
I tested it on a large dataset. Baseline worked fine. This branch OOM'ed a 64GB machine. Log from a successful run: |
|
I thought about the We could make it explicit by renaming it to |
isn't it the property of input graph? we are just changing the internal structure |
|
See the explanation in #9 user - [:livesin] -> city is already a directed graph. We can't be converting a directed graph to a directed graph by using By changing the flag to represent what the code is doing rather than "faking a directed graph to be undirected" we reduce confusion. |
convert_arrow_tables_to_csrunderIcebugMemGraph