Skip to content

update icebug-disk demo-db datasets#3

Merged
adsharma merged 1 commit into
LadybugDB:mainfrom
aheev:update-icedisk-datasets
May 15, 2026
Merged

update icebug-disk demo-db datasets#3
adsharma merged 1 commit into
LadybugDB:mainfrom
aheev:update-icedisk-datasets

Conversation

@aheev
Copy link
Copy Markdown
Contributor

@aheev aheev commented May 15, 2026

expanded datasets to account for more complex queries

context: LadybugDB/ladybug#491

@adsharma
Copy link
Copy Markdown
Contributor

Now the graph returns 7 edges instead of 4.

  Adam|Adam|2023
  Adam|Karissa|2020
  Adam|Zhang|2020
  Karissa|Adam|2022
  Karissa|Zhang|2021
  Noura|Adam|2023
  Zhang|Noura|2022

@adsharma adsharma merged commit 08ff66e into LadybugDB:main May 15, 2026
@adsharma
Copy link
Copy Markdown
Contributor

@aheev should the non icebug formats get an update too to keep the data consistent?

@aheev
Copy link
Copy Markdown
Contributor Author

aheev commented May 16, 2026

@aheev should the non icebug formats get an update too to keep the data consistent?

sure. Are there downstream dependencies on this repo?

@adsharma
Copy link
Copy Markdown
Contributor

As long as we fix the tests we should be good to go. Don't think anyone depends on demo db. If they do, they should be fixed up!

@adsharma
Copy link
Copy Markdown
Contributor

oh - the tests may be spread across many repos, now that we have so many languages and their dependent tests.

@aheev
Copy link
Copy Markdown
Contributor Author

aheev commented May 16, 2026

LadybugDB/ladybug#473 (comment)

Probably easier to create a second demo db with the patterns you want. No one has seen this commit, we could just reset the HEAD to the previous version.

should I instead move icebug-disk completely out of demo-db?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants