You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Medium, security/API surface: src_cpp/main.cpp:12 exports createArrowCSRTestData from the production native
addon. That is test fixture code shipped in the runtime binary, returning unmanaged native pointer-like
Externals. Even if it is not in the public .d.ts, it is still part of the native module surface and gives
consumers a native allocation helper that only exists for tests. This should be behind a test-only build flag,
moved into a separate test addon, or avoided.
Medium, DoS/memory-safety risk: src_js/connection.js:428 validates dstColName in CSR mode but does not validate indptrArraysPtr or numIndptrArrays. Native then uses Uint32Value() at src_cpp/node_connection.cpp:293 and src_cpp/node_connection.cpp:295. Values like -1 can wrap to a huge unsigned count, and TakeArrowArrays reserves/reads that many arrays from a pointer. Validate both counts as positive safe integers in JS and add native range/type checks too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.