Revert "Statically link JSON extension in pybind CI"#20
Merged
Conversation
adsharma
force-pushed
the
revert_static_ext
branch
5 times, most recently
from
14f60fd to
fe12da7
Compare
This reverts commit 13d6905.
adsharma
force-pushed
the
revert_static_ext
branch
2 times, most recently
from
608f5f0 to
1d63362
Compare
adsharma
force-pushed
the
revert_static_ext
branch
from
bb7a59f to
0f4af1b
Compare
adsharma
force-pushed
the
revert_static_ext
branch
from
b109734 to
9cee298
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: LadybugDB/ladybug#462
Summary
This PR keeps the JSON extension dynamically loaded in Python CI instead of statically linking it for the pybind build.
It also tightens Python test fixture cleanup so C API tests explicitly close per-test databases, connections, and async connections. That prevents native scheduler/connection state from leaking across the full test process.
For C API CI, a small
INSTALL json; LOAD json;smoke runs before the full pytest suite. This primes the dynamically downloaded JSON extension path. We have seen crashes during extension LOAD without this priming. Needs further debug.