Update NodeJS package name in README#382
Merged
Merged
Conversation
Contributor
Author
|
Thanks for the merge! @adsharma Do you guys have tasks/accept help with the TypeScript/Node bindings? I am exploring the project and noticed we do not have full type safety yet. I might be able to help |
Contributor
|
@aelmosalamy there were some ideas in the threads from Feb from user @vkozio. #135 (comment) Perhaps triage them and write up a proposal for what makes sense? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I really am not sure why is the official docs giving a non-existent
npmpackage name.Kindly fix to avoid confusion as between the site, docs and Github, there is 3 different variations:
lbug,@ladybug/coreand@ladybugdb/core. It seems like@ladybugdb/coreis the correct one so far: https://www.npmjs.com/package/@ladybugdb/core