ci: add Node version matrix to build-and-deploy Node.js workflow#387
Merged
adsharma merged 4 commits intoApr 21, 2026
Merged
Conversation
Contributor
|
Getting tested here: https://github.com/LadybugDB/ladybug/actions/runs/24730722280 |
adsharma
reviewed
Apr 21, 2026
Contributor
|
@antonymarion could you look into the CI failures? Would love to get this one in before the next release. |
Add Node.js version matrix coverage to build-and-deploy while keeping reusable workflow matrix metadata intact and removing the invalid continue-on-error expression from the reusable workflow call. Made-with: Cursor
antonymarion
force-pushed
the
ci/node-matrix-build-and-deploy
branch
from
c378e87 to
d29b234
Compare
actions/setup-node resolves cache-dependency-path during setup. The lockfile lives in tools/nodejs_api, which is a submodule path and was not present before submodule init, causing cache path resolution failures in CI. Run submodule initialization first so setup-node can resolve tools/nodejs_api/package-lock.json and restore/save npm cache correctly. Made-with: Cursor
Contributor
Remove setup-node cache configuration because the configured lockfile path can be unresolved in this workflow context, causing setup-node to fail before dependency installation. Made-with: Cursor
Contributor
Author
@adsharma you can please relaunch with the last commit on the ladybug original repo. Mine (fork) is failing since link to precompiled liblbug is missing but should be ok on your side |
Contributor
|
Running here: https://github.com/LadybugDB/ladybug/actions/runs/24739853324 Also needs: |
Contributor
|
Succeeded! Please cherry pick d20cf91 and we should be good to go. |
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR moves expanded Node.js version coverage to the canonical build/deploy workflow (instead of
ladybug-nodejs), following review feedback on the now-closed PRLadybugDB/ladybug-nodejs#9(comments from @adsharma).Changes
build-nodejsinbuild-and-deploy.yml:22(default release path)20(additional validation)24(non-blocking canary viacontinue-on-error)nodeVersionandartifactSuffixtonodejs-workflow.yml.actions/setup-node@v4innodejs-workflow.ymlwith npm cache enabled.-node20,-node24) to avoid collisions across matrix runs.Why
Reference
LadybugDB/ladybug-nodejs#9