More local rel table fixes for MVCC and read-your-writes#416
Merged
Conversation
LogicalInsert and LogicalMerge were only adding inserted node internal IDs to schema scope. Inserted relationship internal IDs could therefore drop out of scope, which changed the planner/executor state reaching rel insertion and caused the q2 read-your-writes repro in the PR description to produce the wrong PO edges even after the local storage scan fixes. Add inserted rel internal IDs to both factorized and flat schemas so rel insertions preserve the expected schema contract through planning and execution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #378