ci: publish @ladybugdb/core-darwin-x64 to npm (follow-up to #427)#437
Merged
adsharma merged 1 commit intoLadybugDB:mainfrom Apr 29, 2026
Merged
Conversation
The 0.16.0 package.json already declares @ladybugdb/core-darwin-x64@0.16.0 in optionalDependencies, and the nodejs-workflow.yml matrix already builds the macos-15-intel / darwin-x64 native module. The packaging step also produces lbug-darwin-x64.tar.gz. However, the three npm publish loops in build-and-deploy.yml omit lbug-darwin-x64.tar.gz, so the sub-package is never uploaded to the registry. Intel-Mac users therefore hit a 404 on the optional dependency, fall back to the source build, and fail because lbug-source/ is not shipped in the npm tarball. Add lbug-darwin-x64.tar.gz to the dry-run, nightly and latest publish loops, and drop the now-unnecessary continue-on-error guard on the macos-15-intel matrix leg in nodejs-workflow.yml so a future darwin-x64 build failure becomes a real signal instead of a silent gap.
Contributor
|
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #436. Follow-up to the recently merged #427.
@ladybugdb/core@0.16.0'spackage.jsondeclares@ladybugdb/core-darwin-x64@0.16.0inoptionalDependencies, butthe sub-package was never actually published —
npm view @ladybugdb/core-darwin-x64returns 404. PR #427 wired theartifact download and tarball verification, but the three
npm publishloops further down inbuild-and-deploy.ymlstillskip
lbug-darwin-x64.tar.gz. This PR closes that last gap.3 insertions / 7 deletions across 2 files.
Changes
.github/workflows/build-and-deploy.yml— addlbug-darwin-x64.tar.gzto the dry-run, nightly and latestnpm publishloops, alongside the other per-platform tarballsthat Fix nodejs deploy macOS x64 artifact handling #427 had already added to the verification loop just above.
.github/workflows/nodejs-workflow.yml— drop thecontinue-on-error: matrix.os == 'macos-15-intel'guard onbuild-nodejs. With the publish path now wired up end-to-end,a darwin-x64 build break should be a real CI signal, not a
silent gap.
Why this is safe
precompiled-bin-workflow.ymlproduces darwin-x64liblbug.anodejs-workflow.ymlbuildslbugjs-darwin-x64.nodedeploy-nodejsdownloadsmac-nodejs-module-x64lbug-darwin-x64.tar.gzpackage.jsondeclares the optional depnpm publishactually uploads itThis PR doesn't add any new build work; it only consumes an
artifact that the matrix is already producing today and that #427
already validated.
The publish loops keep their existing
[ -f \"$tarball\" ] || continueguard, so even if the artifact were missing the loop would just
skip it — graceful degradation is preserved.
Test plan
CI changes can't really be unit-tested; the workflow itself is the
test harness. Verification path:
Build, Deploy, and Test→build-nodejsjob goes greenfor
macos-15-intel. (It was already building successfullyunder the old
continue-on-error; this PR just stops hidingfailures.)
deploy-nodejsstep "Deploy to npm.js dry run" log showslbug-darwin-x64.tar.gzbeing processed in the loop.npm view @ladybugdb/core-darwin-x64 versionreturns thereleased version instead of 404.
npm install @ladybugdb/coreon an Intel Mac(macOS 13.3+, Node 22) succeeds without falling back to
source build.
Notes for maintainers
I read #299 about the Intel Mac platform winding down. Worth
flagging that all the heavy lifting (precompiled lib, native
module build, packaging, verification) is already happening on
every release thanks to #427 and earlier work — the incremental
cost of publishing the sub-package is essentially zero. Happy to
iterate on the patch if you'd prefer a different shape (e.g.
driving the publish list off a shared variable rather than
repeating it three times).