Skip to content

Support proxy env for extension downloads#511

Merged
adsharma merged 1 commit into
mainfrom
fix-extension-proxy-env
May 22, 2026
Merged

Support proxy env for extension downloads#511
adsharma merged 1 commit into
mainfrom
fix-extension-proxy-env

Conversation

@adsharma
Copy link
Copy Markdown
Contributor

@adsharma adsharma commented May 22, 2026

Fixes: #415

Summary

  • read Ladybug-specific and standard proxy environment variables for extension downloads
  • apply the resolved proxy settings to httplib clients used for extension libraries and installers
  • document the supported variables and add focused proxy parsing/env selection tests

Root Cause

Ladybug used httplib directly for extension downloads, but did not pass proxy settings into the client. httplib supports proxies through set_proxy, but it does not automatically consume process proxy environment variables.

Validation

  • cmake --build build/release --target types_test
  • build/release/test/common/types_test '--gtest_filter=ExtensionProxyTest.*'
  • git diff --check

@adsharma adsharma marked this pull request as ready for review May 22, 2026 17:33
@adsharma adsharma merged commit 80a3c04 into main May 22, 2026
4 checks passed
@adsharma adsharma deleted the fix-extension-proxy-env branch May 22, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: LadybugDB doesn't support a network proxy for downloading extensions

1 participant