Add WAL TypeSpec generation#568
Merged
Merged
Conversation
f6c239f to
8874036
Compare
Contributor
Author
|
For our WAL case, generalizing polymorphic payload serialization would take three pieces:
So TypeSpec can represent the shape, but it won’t automatically know Ladybug’s C++ factory/ownership conventions. The useful next step would be adding a small WAL-specific metadata layer for discriminated payloads rather than hardcoding AlterTableEntryRecord and CreateCatalogEntryRecord branches by record name. |
3b2a1ad to
9bc1b58
Compare
9bc1b58 to
5d2f343
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #404
Summary
Manual Generation
AlterTableEntryRecord
CreateCatalogEntryRecord
Their polymorphic payload serialization is emitted from special branches in wal_record_header.h.j2 and wal_record_source.cpp.j2
Validation