Skip to content

Fix wasm lbug_shared compatibility alias#578

Merged
adsharma merged 1 commit into
mainfrom
fix/wasm-lbug-shared-alias
Jun 8, 2026
Merged

Fix wasm lbug_shared compatibility alias#578
adsharma merged 1 commit into
mainfrom
fix/wasm-lbug-shared-alias

Conversation

@adsharma

@adsharma adsharma commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add a wasm-only CMake alias so existing lbug_shared consumers resolve to the static lbug target when shared builds are disabled for Emscripten.
  • Document why the alias is intentionally static-backed for wasm.

Root cause

The wasm build now intentionally disables BUILD_SHARED_LBUG and builds only the static lbug target, but nightly wasm test helper targets still link through the legacy lbug_shared target name. That produced -llbug_shared during the Emscripten link even though no shared library is built.

Validation

  • cmake -B /private/tmp/lbug-cmake-wasm-alias-check -G Ninja -DBUILD_SHELL=OFF -DBUILD_TESTS=OFF -DBUILD_SINGLE_FILE_HEADER=OFF .
  • git diff --check -- src/CMakeLists.txt

@adsharma adsharma marked this pull request as ready for review June 8, 2026 15:49
@adsharma adsharma force-pushed the fix/wasm-lbug-shared-alias branch from 7f495e7 to 9fb95e1 Compare June 8, 2026 15:57
@adsharma adsharma merged commit b105e22 into main Jun 8, 2026
16 checks passed
@adsharma adsharma deleted the fix/wasm-lbug-shared-alias branch June 8, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant