Conversation
Require OpenSSL 3 and prefer imported targets; update CI to point to libssl.so.3/libcrypto.so.3 This ensures builds link against OpenSSL 3 (libssl.so.3) rather than older libssl.so.1 which is EOL.
set EXTRA_CMAKE_FLAGS to point to libssl.so.3/libcrypto.so.3 This helps cibuildwheel/CMake locate OpenSSL v3 inside manylinux images so builds link against OpenSSL 3.
openssl3/openssl3-devel or openssl3/openssl3-dev Use openssl3 packages on dnf/apk paths so CI containers use OpenSSL 3 instead of older openssl-devel/dev packages.
Contributor
Author
9974d27 to
b808747
Compare
…CLUDE_DIR to EXTRA_CMAKE_FLAGS Add -DOPENSSL_ROOT_DIR=/usr and -DOPENSSL_INCLUDE_DIR=/usr/include so CMake FindOpenSSL can find OpenSSL 3 headers during configure.
…nd alpine Set -DOPENSSL_ROOT_DIR, -DOPENSSL_INCLUDE_DIR and explicit library paths to the openssl3 layout: - x86_64/manylinux: /usr/lib64/openssl3 and /usr/include/openssl3 - alpine/musl: /usr/lib/openssl3 and /usr/include/openssl3
Set EXTRA_CMAKE_FLAGS in the Linux compat build step so CMake FindOpenSSL can locate OpenSSL 3 headers and libs installed by openssl3 packages inside the manylinux container.
…_FLAGS dynamically Detect libssl.so.3 via ldconfig or common candidate paths and export -DOPENSSL_CRYPTO_LIBRARY/-DOPENSSL_SSL_LIBRARY before building so Ubuntu runners find OpenSSL 3.
23d98e2 to
b6197de
Compare
…ng Linux paths to macOS/Windows
…inks for manylinux
…to.so.3 soname symlinks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: LadybugDB/extensions#11