This repository was archived by the owner on Oct 12, 2025. It is now read-only.
Conversation
DarkRRb
requested review from
a user,
CrackTC,
Decrabbityyy,
Executor-Cheng,
KusaGumina,
Linwenxuan04,
Copilot,
pk5ls20 and
sisi0318
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a bug where an AtEntity following a ForwardEntity was not being properly filtered.
- Added logic to set the Uin value from a sliced attribute buffer when it is initially 0.
- Included a comment that appears unprofessional in the new code.
| MentionExtra info = Serializer.Deserialize<MentionExtra>(extra.AsSpan()); | ||
| if (info.Type != 2) return null; | ||
|
|
||
| // shit! |
There was a problem hiding this comment.
[nitpick] The comment contains unprofessional language; consider removing or replacing it with a descriptive comment that explains the purpose of the code change.
Suggested change
| // shit! | |
| // If Uin is 0, attempt to extract it from Attr6Buf (if its length is greater than 11). |
…he-problem-that-AtEntity-after-ForwardEntity-was-not-filtered
pk5ls20
approved these changes
Apr 27, 2025
DarkRRb
deleted the
darkrrb/fix/Fixed-the-problem-that-AtEntity-after-ForwardEntity-was-not-filtered
branch
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.