This repository was archived by the owner on Oct 12, 2025. It is now read-only.
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts the log level for unsupported SSOFrame messages from a warning to an informational log. This update aims to reduce noise by treating these messages as less severe.
- The log method for unsupported commands has been changed from warning to information.
- The debug log remains in place for additional context.
Comments suppressed due to low confidence (1)
Lagrange.Core/Internal/Context/ServiceContext.cs:97
- If lowering the log level is intentional, consider adding a comment or updating the related documentation to clarify the decision and alert monitoring teams of the change.
Collection.Log.LogInfo(Tag, "$Unsupported SSOFrame Received: {packet.Command}");
KusaGumina
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.