Skip to content
This repository was archived by the owner on Oct 12, 2025. It is now read-only.

[Core] Adjust log level for Unsupported SSOFrame message#829

Merged
NoirHare merged 1 commit intomasterfrom
darkrrb/fix/Adjust-log-level-for-Unsupported-SSOFrame-message
May 15, 2025
Merged

[Core] Adjust log level for Unsupported SSOFrame message#829
NoirHare merged 1 commit intomasterfrom
darkrrb/fix/Adjust-log-level-for-Unsupported-SSOFrame-message

Conversation

@NoirHare
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adjusts the log level for unsupported SSOFrame messages from a warning to an informational log. This update aims to reduce noise by treating these messages as less severe.

  • The log method for unsupported commands has been changed from warning to information.
  • The debug log remains in place for additional context.
Comments suppressed due to low confidence (1)

Lagrange.Core/Internal/Context/ServiceContext.cs:97

  • If lowering the log level is intentional, consider adding a comment or updating the related documentation to clarify the decision and alert monitoring teams of the change.
Collection.Log.LogInfo(Tag, "$Unsupported SSOFrame Received: {packet.Command}");

@NoirHare NoirHare merged commit 48c8b3c into master May 15, 2025
8 checks passed
@NoirHare NoirHare deleted the darkrrb/fix/Adjust-log-level-for-Unsupported-SSOFrame-message branch May 15, 2025 07:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants