Skip to content
This repository was archived by the owner on Oct 12, 2025. It is now read-only.

Conversation

@DarkRRb
Copy link
Collaborator

@DarkRRb DarkRRb commented May 16, 2025

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses the filtering issue for invalid images by updating the URI validation to only consider absolute URIs.

  • Updated image URL validation logic in OldAndInvalidImageFilterRule.
  • Ensures that only images with absolute URLs pass the well-formed check.
Comments suppressed due to low confidence (1)

Lagrange.Core/Message/Filter/Rule/OldAndInvalidImageFilterRule.cs:17

  • The change to only accept absolute URIs enhances the filtering logic; however, please verify that no valid relative URIs are expected elsewhere in the application.
if (!Uri.IsWellFormedUriString(image.ImageUrl, UriKind.Absolute)) return ImageType.Invalid;

@DarkRRb DarkRRb merged commit 7a108da into master May 16, 2025
8 checks passed
@DarkRRb DarkRRb deleted the darkrrb/fix/Failed-to-filter-invalid-images-in-special-cases branch May 18, 2025 12:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants