[Core] Add FlashTransfer.UploadFile appId parameter, fix friend image upload#68
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds an appId parameter to the FlashTransfer.UploadFile method and fixes friend image upload functionality by using correct application IDs for different message types.
- Adds appId parameter to FlashTransfer.UploadFile method to support different file types
- Updates image upload logic to use proper app IDs (1406 for friend images, 1407 for group images)
- Improves documentation with comprehensive app ID mapping in comments
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Lagrange.Core/Message/Entities/ImageEntity.cs | Updates FlashTransfer call to include appId parameter and uses IsGroup property |
| Lagrange.Core/Internal/Packets/Service/FlashTransferUploadReq.cs | Adds comprehensive comment documenting different appId values for various file types |
| Lagrange.Core/Internal/Context/FlashTransferContext.cs | Adds appId parameter to UploadFile and UploadChunk methods, removes hardcoded value |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
KusaGumina
approved these changes
Sep 26, 2025
Wesley-Young
approved these changes
Sep 26, 2025
Bemly
pushed a commit
to Bemly/CharonAnchor
that referenced
this pull request
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.