fix(#367): derive subprocess cwd from __file__ in lifespan test#368
Merged
NoveliaYuki merged 1 commit intoMay 11, 2026
Conversation
The empty-token startup-guard test spawned its subprocess with cwd set to a hardcoded absolute Linux path that only existed on one developer's machine. Anywhere else the subprocess silently failed to start with a working directory error, masking the actual guard behavior under test. Resolve the repo root from the test file's location instead so the test runs portably on macOS, Linux, and CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The empty-token startup-guard test in the new KB server hardcoded its subprocess
cwdto one developer's local Linux path. Outside that one machine the subprocess could not start, so the test failed for the wrong reason on macOS, other Linux checkouts, and CI alike.Changes
lamb-kb-server/repo root from the test file's own location (Path(__file__).resolve().parents[2]) and pass that tosubprocess.run(..., cwd=...).tests/integration/test_main_lifespan.pyis touched; all 12 tests in the file still pass.Related