fix(#377): migrate url_import to firecrawl-py 2.x API#378
Merged
NoveliaYuki merged 1 commit intoMay 12, 2026
Merged
Conversation
firecrawl-py >= 2.x renamed crawl_url() to crawl() and replaced the params dict with keyword arguments + a ScrapeOptions value object. The returned doc.metadata is now a Pydantic model with attribute access; support both shapes for forward compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
URL imports fail at runtime with
AttributeError: 'Firecrawl' object has no attribute 'crawl_url'. The plugin was written against firecrawl-py 0.x; the dependency currently in the library-manager container is firecrawl-py 4.25.2, which renamed the entry points and reshaped the response objects.Changes
app.crawl_url(url, params={...}, poll_interval=5)withapp.crawl(url, **kwargs, scrape_options=ScrapeOptions(formats=["markdown"]), poll_interval=5)— keyword arguments now carrylimit,max_discovery_depth,crawl_entire_domain,allow_external_linksdirectly.DocumentMetadata(attribute access onsource_url/title) and the legacy dict form (camelCasesourceURL) for forward compatibility.The migration is dependency-only — no public API of the plugin changes, no other call sites needed updates.
Verification
library-manager/tests/— 52/52 passing against the patched plugin.https://example.com, item reaches statusready, content endpoint returns non-empty markdown.Related