Skip to content

Add FPS config for capture command #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Add FPS config for capture command #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/lib/screenshot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ const BROWSER_FIREFOX = 'firefox';
const BROWSER_EDGE = 'edge';
const EDGE_CHANNEL = 'msedge';
const PW_WEBKIT = 'webkit';
const MIN_RESOLUTION_HEIGHT = 320;

export async function captureScreenshots(ctx: Context, screenshots: WebStaticConfig): Promise<number> {
// Clean up directory to store screenshots
Expand Down Expand Up @@ -53,8 +54,8 @@ export async function captureScreenshots(ctx: Context, screenshots: WebStaticCon
let { width, height } = ctx.webConfig.viewports[k];
let ssName = `${browserName}-${width}x${height}-${screenshotId}.png`
let ssPath = `screenshots/${screenshotId}/${ssName}.png`
await page.setViewportSize({ width, height})
await page.screenshot({ path: ssPath });
await page.setViewportSize({ width, height: height || MIN_RESOLUTION_HEIGHT })
await page.screenshot({ path: ssPath, fullPage: height ? false: true });

let completed = (i == (totalBrowsers-1) && j == (totalScreenshots-1) && k == (totalViewports-1)) ? true : false;
browserName = browserName === BROWSER_SAFARI ? PW_WEBKIT : browserName;
Expand Down