Skip to content

Only trim and not replace spaces in between snapshot name #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
Merged

Only trim and not replace spaces in between snapshot name #422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lib/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export default async (ctx: Context): Promise<FastifyInstance<Server, IncomingMes
throw new Error(`Invalid snapshot options; rejectionThreshold (${snapshot.options.rejectionThreshold}) must be greater than approvalThreshold (${snapshot.options.approvalThreshold})`);
}
}
snapshot.name=snapshot?.name?.trim().replace(/\s+/g,'_');
snapshot.name=snapshot?.name?.trim();

// Fetch sessionId from snapshot options if present
const sessionId = snapshot?.options?.sessionId;
Expand Down Expand Up @@ -243,7 +243,7 @@ export default async (ctx: Context): Promise<FastifyInstance<Server, IncomingMes
try {
ctx.log.debug(`request.query : ${JSON.stringify(request.query)}`);
const { contextId, pollTimeout, snapshotName: rawSnapshotName } = request.query as { contextId: string, pollTimeout: number, snapshotName: string };
const snapshotName = rawSnapshotName?.trim().replace(/\s+/g,'_');
const snapshotName = rawSnapshotName?.trim();
if (!contextId || !snapshotName) {
throw new Error('contextId and snapshotName are required parameters');
}
Expand Down