Missing effects of Empathy + Spirit Link + Wyvern Level Up

[mogulbgod]

This is a long one guys and gals so please bare with me. @ChrisCoffey had an idea that an update to DRG Empathy from 2014 wasn't being applied properly or at all. He explained it to me and asked if I could look into it for him which I did. Combing through LSBs file and looking at DRG, Empathy, Spirit Link, and Wyvern levels I did not find what he was looking for.

What Was He Looking For?

In September of 2014 SE updated Empathy and Spirit Link to allow the Dragoon to gain 20% Attack, 20% Defense, and 10% Job Ability Haste from your Wyvern. https://www.ffxiah.com/forum/topic/44396/sigurds-descendants-the-art-of-dragon-slaying/#_user-all-things-dragoon-merits

Chris researched this a bit more and found the information on it was very scant and that BG and FFXIclopedia didn't have the information listed either. He found a reference to it at the above link and shared it with me. After a bit of digging I also found it on the official SE forum. https://forum.square-enix.com/ffxi/archive/index.php/t-44090.html?s=8275a7c616e312a79bcefbca7b1cb4bf

The patch notes clearly state that the Dragoon gets buffed when the Wyvern levels up.

What I found.

After going through the Lua files on the LSB Github I didn't see anything that allowed for the Dragoon itself to be buffed when the Wyvern leveled up. https://github.com/LandSandBoat/server/blob/base/scripts/globals/job_utils/dragoon.lua

What's funny is that LSB actually references the guide/write-up from FFXIAH.com that I linked up top in that Lua file.

BG-Wiki has some info listed under the Spirit Link page that seems incorrect as it says the Wyvern gets the atk and Def buff while the master gets the haste buff. https://www.bg-wiki.com/ffxi/Spirit_Link

Also on BG-Wiki is a time line of events and updates and from September 2014 they also have listed verbatim what SE had posted for patch notes. https://www.bg-wiki.com/ffxi/The_History_of_Final_Fantasy_XI/2014

[WinterSolstice8]

exp gain comes from a listener here

server/scripts/globals/pets/wyvern.lua

Line 174 in 62f01f3

master:addListener('EXPERIENCE_POINTS', 'PET_WYVERN_EXP', function(playerObj, mobObj, exp)

[WinterSolstice8]

Empathy adds exp here

server/scripts/globals/job_utils/dragoon.lua

Line 338 in 62f01f3

xi.job_utils.dragoon.addWyvernExp(player, 200 * empathyTotal)

the buffs are added here

server/scripts/globals/job_utils/dragoon.lua

Line 824 in 62f01f3

xi.job_utils.dragoon.addWyvernExp = function(player, exp)

afaik it's accurate but if something is wrong we can fix it

[mogulbgod]

it's more so about the boosts to the DRG him/herself. When Wyvern gains a level the DRG gets buffs (ATK, DEF, Haste) every time the DRG levels up (up to 5x AFAIR) unless you have max Empathy merits then it takes one Wyvern level OR a single use of Spirit Link to gain the max buffs.

[mogulbgod]

I don't know lua well yet but I'm willing to help as much as I can with the project