Salvage

[GanimanSwift]

I am curious to what the status is of work being done on Salvage. Is it inactive, on hold, or something else?

I was playing with the code for it and testing it out. After some minor tweaks, Zhayolm Remnants seems to "work". I can enter, mobs spawn, I can progress floors and get rewards for finishing. The cell that removes your subjob restriction was not working properly - it removes the status icon, but the initial effect actually removes the subjob instead of just setting the level to 0 as I understand retail to work. I put in a simple fix to solve that and now subjobs are restored as expected. A handful of mobs also had a very low attack delay set in their lua files (possibly outdated due to other changes in how LSB handles delays since this was last touched), and adding a 0 to each solves it, for example: a delay of 700 on Puks vs 7000. Updating the delays by x10 makes the mob delay seem to match the capture I checked.

It is possible some mob placement is incorrect in Zhayolm - I think I saw Puks where some Poroggo Gents should be - but I'd need to double check the capture more closely. It seems like at least Zhayolm Remnants was getting close to a nice working state. I think I could enter Bhaflau Remnants, but the chest didnt work and there are no mobs, portal isn't working, etc.. and the others didn't let me enter at all.

Is this worth continuing to work on? I don't want to overlap with something someone else might already be doing. And I don't know if there are plans to yank all this out and replace it with new code. If I can manage to put some time into this and submit a PR I'll take a shot.

[zach2good]

Preface: I'm an architecture person; I don't go near gameplay content much anymore. My only understanding of Salvage is that it's all the "Remnants" encounters

KO has this PR open: #7131 - where there's only some ID shifts and styling stuff pending. Typically, KO's work comes straight from Eden, so it's well-researched, battle-tested and complete. Check to see what you've done vs what they've done.