[GM] prefix before names in chat

[ShiroiBara]

Hi! I have set up server and client according instruction here. I made character and made it GM 4 level. I toggle GM with !togglegm command. But when I send any messages to chat or via /tell /yell and other chat commands it never shows for others (I run 2 different clients with 2 different characters online for full test) like [GM}Player but always only has just Player name. I checked that part of code: https://github.com/LandSandBoat/server/blob/base/src/map/packets/s2c/0x017_chat_std.cpp Looks like I need attr=01 flag on to add {GM} before name. But I can't achieve it because some records in SQL table missing and if (PChar->visibleGmLevel >= 3 && sender.empty()) or if (gmLevel >= 3 && name.empty()) always false. Is this because this part of code outdated? Do I need manually adjust it and removes some checks there? Or GMs using special commands for chat which shows their [GM] prefix for other players? I even tried create new fresh character on second account and !promote it to level 3 and !togglegm on it too, but chat still has no [GM] prefix. Dose info here https://github.com/atom0s/XiPackets/blob/main/world/server/0x0017/README.md still actual or modern clients no longer using atrr=01 flag anymore?

[Mortalelite]

I would say make a issue on this, as here it can get overlooked and missed.

I did notice that when a char is set as GM and you use the /say and /shout it does show up [GM] before the player, and that's what the second char does see. The GM player that is sending does not see the [GM] only the other char's

With /tell you don't see [GM] from the responding GM. I remember seen that once before.

/yell and /party does not show up from a [GM]

I did not get to test /linkshell but I do recall it doing it back in the day or least thought it did.

Not sure the behavior on retail for those. I know /tell did on retail not sure if that was changed or not. That was way you knew was talking to a GM via /tell

[sruon]

Are you confirming and observing the lack of the [GM] prefix from the 2nd character PoV?

The sender does not get the echo packet and as such does not get the flag set so from their perspective it will just show "Myname: hello!"

[ShiroiBara]

I did /tell from GM character to another, no prefix, did /yell /say/ shout, same. Both were in same zone. Main character has level 4 according setup instructions and !togglegm make it with pink font in name and SE icon. Second character was !promote to level 3 toggled GM as well with red font name and GM icon. Both can /tell each other but both has no [GM] prefix in chat regardless how they look like (visible GM with special icons and font or just regular players). Has not tested party or linkeshell chats.

[ShiroiBara]

I have removed sender.empty() from the code and tested it. Everything is working except /tell has no prefix when GM is located in a different zone than the target player.

This could be another check somewhere else in other .cpp files.

When GM skin is turned off (!togglegm), there is also no prefix, but I think that's OK.

I also checked party chat:
if GM skin is ON, even when GM is in another zone, messages still have [GM] prefix in chat, and toggling skin off/on does not affect it.

I guess this part of the code needs to be tested deeper and might need changes unless developers want to keep it in the current state.

There are several small bugs in scripts, for example:
!promote does not remove GM skin when a player is demoted back to regular rank 0.

---

Chat screenshot

---

Packet 0x17 test addon

You can use this small addon to check flags in packet 0x17.

You need to run it on a second account unless you send tells to yourself, which triggers packet 0x17 from server back to you.

addon.name    = 'gm_test'
addon.author  = 'debug'
addon.version = '1.0'

require('common')
local ffi = require('ffi')

print('[gm_test] Loaded')
print('[gm_test] Monitoring packet 0x0017 - showing Kind and Attr only')

ashita.events.register('packet_in', 'gm_test_cb', function(e)
    if e.id ~= 0x0017 and e.id ~= 0x17 then return end

    local kind = ffi.cast('uint8_t*', e.data)[4]
    local attr = ffi.cast('uint8_t*', e.data)[5]

    print(string.format('[gm_test] Kind: 0x%02X (%d) | Attr: 0x%02X (%d)',
        kind, kind, attr, attr))
end)