Skip to content

[core] Don't clobber look string data for entities that dont have it#10044

Merged
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
WinterSolstice8:npc_look_size_stuff
May 16, 2026
Merged

[core] Don't clobber look string data for entities that dont have it#10044
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
WinterSolstice8:npc_look_size_stuff

Conversation

@WinterSolstice8
Copy link
Copy Markdown
Contributor

@WinterSolstice8 WinterSolstice8 commented May 16, 2026

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

tl;dr: we don't currently store model hitbox size and graph size for non player/mob/pet so we don't want to override what was memcpyed from look string/namevis/whatever

Steps to test these changes

!cs 705 in whitegate
before:
image

after:
image

co-authored-by: slashtangent <steve50013@gmail.com>
@Xaver-DaRed Xaver-DaRed merged commit 6a6232a into LandSandBoat:base May 16, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants