Skip to content

[lua] Nyzul fixes: NM coffers, Friars Lanterns, removePathos#10053

Merged
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
wccbuck:nyzul-fixes
May 17, 2026
Merged

[lua] Nyzul fixes: NM coffers, Friars Lanterns, removePathos#10053
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
wccbuck:nyzul-fixes

Conversation

@wccbuck
Copy link
Copy Markdown
Contributor

@wccbuck wccbuck commented May 17, 2026

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

This PR fixes three issues with Nyzul Island:

  1. "Friar's Lantern" mobs in Nyzul did not count towards "Eliminate" objectives because their file was named 'Friar_s_Lantern.lua'. Removed the erroneous underscore in the filename.
  2. Vigil weapons / coffers did not drop for about 2/3rds of intended NMs in Nyzul because ID.mob.TAISAIJIN is the first instance of Taisaijin in Nyzul, which is not the end of the NM list.
  3. xi.nyzul.removePathos attempted to reference a nil "ID" property instead of "textID".

Steps to test these changes

Ran Nyzul Isle, forced "arcana" floors so I could confirm that Friar's Lantern mobs counted towards Eliminate objectives
Confirmed pathos status effects were cleared on floor change
Confirmed the NM "Maighdean Uaine" dropped a vigil weapon

@wccbuck wccbuck changed the title Nyzul fixes: NM coffers, Friars Lanterns, removePathos [lua] Nyzul fixes: NM coffers, Friars Lanterns, removePathos May 17, 2026
@Xaver-DaRed Xaver-DaRed merged commit 0fca67c into LandSandBoat:base May 17, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants