Skip to content

[trust, sql, core, lua] Passive trust movement/animation gambits and aura effects#10093

Merged
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
Omnione:trust_passive
May 23, 2026
Merged

[trust, sql, core, lua] Passive trust movement/animation gambits and aura effects#10093
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
Omnione:trust_passive

Conversation

@Omnione
Copy link
Copy Markdown
Contributor

@Omnione Omnione commented May 23, 2026

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

This pull request fixes Trust "aura" effects and refactors several Trust scripts to support these auras, adding new status effects, effect scripts.

Trust Aura Effects Implementation:

  • Added/Fixed Trust aura effects for CHR, Haste, EXP, Accuracy, Refresh, Regen, and Magic Attack
  • Implemented effect scripts for each new aura

Trust Script Refactors and Additions:

  • Refactored Trust spawn logic for Brygid, Kupofried, Kuyin Hathdenna, Moogle, Sakura, and Star Sibyl to:
    • Set consistent movement mode (NON_COMBAT)
    • Apply a 12-yalm aura range (tested and confirmed on retail)
    • Add their respective aura status effect on spawn
    • Add a random animation gambit and disable auto-attack
  • Added new Trust scripts for Cornelia and Matsui-P (Matsui-P is not a passive trust but its there for completions sake)
  • Adding a server setting to enable and disable Cornelia and Matsui-P: 0 = none / 1 = Cornelia / 2= Matsui-P, the spelss get added automatically when a players spell list is loaded/reloaded.

AI/Gambit System:

  • Added new AI condition, reaction, and selection types for timer-based and random animation gambits.

Trust Movement:

  • Fixed roaming spacing between trust to the correct distance and improved the follow behaviour to better match retail.
  • Introduced a new NON_COMBAT movement type for Trusts, used for aura-providing Trusts to follow party members appropriately as retail does.

Gameplay/Balance Improvements:

  • Trust auras now stack with player-cast Indi/Geo effects, and some provide additional bonuses (e.g., skillup rates, EXP bonus) for party members within range.

Steps to test these changes

  1. Call out each of the passive trusts and observe the aura effect is correct and gives the correct values for the level.
  2. Move around while not in combat and the trust should stay in formation with correct distances between them as retail does.
  3. Call out some aura trusts and cast the same geo/indi effect to check they stack.
  4. Enable Cornelia in the server settings and log in, she should be in the players trust list as long as the player has a trust permit (Note: on retail, if Cornelia is available and you complete the trust quest for the permit, you will need to zone before she shows in the trust list, this server setting will work the exact same way)
  5. Try and move away from a passive trusts aura (12+ yalms) the aura should wear off after a few seconds or less.

Comment thread scripts/effects/trust_aura_acc.lua Outdated
Comment thread scripts/effects/trust_aura_exp.lua Outdated
Comment thread scripts/enum/effect.lua Outdated
Comment thread scripts/actions/spells/trust/brygid.lua Outdated
Comment thread scripts/actions/spells/trust/kuyin_hathdenna.lua
Comment thread src/map/ai/controllers/trust_controller.cpp
Comment thread scripts/actions/spells/trust/brygid.lua Outdated
Comment thread scripts/effects/trust_aura_acc.lua Outdated
@Omnione Omnione force-pushed the trust_passive branch 2 times, most recently from 472bf7a to e40f972 Compare May 23, 2026 18:53
@Xaver-DaRed Xaver-DaRed enabled auto-merge May 23, 2026 23:12
@Xaver-DaRed Xaver-DaRed merged commit b4bae55 into LandSandBoat:base May 23, 2026
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants