Skip to content

[LUA/SQL] Add Divine Interference quest and instance#5826

Closed
ampitere wants to merge 1 commit intoLandSandBoat:basefrom
ampitere:add_divine_interference_quest_instance
Closed

[LUA/SQL] Add Divine Interference quest and instance#5826
ampitere wants to merge 1 commit intoLandSandBoat:basefrom
ampitere:add_divine_interference_quest_instance

Conversation

@ampitere
Copy link
Copy Markdown
Contributor

@ampitere ampitere commented May 24, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Adds Divine Interference quest and instance. Created based on multiple captures, videos, and wiki information:

https://www.bg-wiki.com/ffxi/Divine_Interference
https://wiki.ffo.jp/html/19593.html
https://www.youtube.com/watch?v=fkIgQxGs9qE (note the first 2 CS in this capture are actually for Unwavering Resolve)
https://www.youtube.com/watch?v=tEDcCLBs9Yk
https://drive.google.com/file/d/1aBexVwCy0inuYlDCfj8Ng_6JpCJWLnNG/view (shows the correct trigger area for starting)
https://www.youtube.com/watch?v=tTrwLPHaRUU

Steps to test these changes

  1. !addmission 4 47 (Eternal Merecenary)
  2. !addquest 6 74 (Waking the Colossus)
  3. !completequest 6 74
  4. Naja Salaheem, !pos 22.700 -8.804 -45.591 50
  5. Imperial Whitegate, !pos 152.8295 -2.2 0.0613 50
  6. !additem slab_of_plumbago 3 (alternatively !addkeyitem lightning_cell but you still need to trigger the CS at the door)
  7. Acid-Eaten Door, !pos 271.9045 -32 -88 61
  8. Blank Lamp, !pos 209.3953 0.05 20.0207 72
  9. Runic Seal, !pos 125.4569 0 19.9914 72
  10. Naja Salaheem, !pos 22.700 -8.804 -45.591 50

To test just the instance use !instance 7702

TODO

  • Get win CS working, doesn't play for some reason (Alzadaal Undersea Ruins - 309 can be seen at this timestamp https://www.youtube.com/watch?v=fkIgQxGs9qE&t=2498s this also affects 307 which is the CS for Waking the Colossus instance win)
  • Balance the fight, feels a bit overtuned for 75 right now
  • Review mob skills
  • One of the params for event 930 (potentially others as well?) is the player's current mercenary rank. Currently says Private Second Class which is from capture data

{
function(player, prevZone)
if quest:getVar(player, 'Prog') == 4 then
return 309 -- correct cs from capture but doesn't play for some reason?
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't figure out why this cutscene doesn't work, tried passing it more params but doesn't seem to make a difference. Tried !cs and !exec player:startEvent. Event can be seen in a capture here: https://www.youtube.com/watch?v=fkIgQxGs9qE&t=2498s

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also seems to affect the same CS for Waking the Colossus which is event 307.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was thinking about this. Are there packet caps from the fight? I wonder if there's a text table change or event flag that needs to be set to support displaying the event.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stayed up late with him one night trying to get this right. We emulated every packet exactly as the capture and verified with Captain that they were the same.

My best guess is some npc doesn't have the right properties and is causing the cutscenes to not proceed, but we tweaked every one in the capture to have exactly the same values and still would black screen.

Also I highly suspect amp moved on, I haven't heard from him in months

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at this the other day coincidentally and I'm more or less thinking the same thing, I'm leaning towards needing the 0x00E entity update packet code fixed before looking more into this

@ampitere ampitere force-pushed the add_divine_interference_quest_instance branch from eac4af7 to 67656f2 Compare May 24, 2024 07:19
@ampitere ampitere changed the title [LUA/SQL] Add Divine Intereference quest and instance [LUA/SQL] Add Divine Interference quest and instance May 24, 2024
@ampitere ampitere force-pushed the add_divine_interference_quest_instance branch from 67656f2 to 03cc4d0 Compare May 24, 2024 21:33
@ampitere ampitere force-pushed the add_divine_interference_quest_instance branch from 03cc4d0 to 2de3fc1 Compare May 25, 2024 23:52
@ampitere
Copy link
Copy Markdown
Contributor Author

I have Waking the Colossus completed as well but will keep it separate for now. Still can't figure out what the issue is with CS 307 and 309.

@sruon
Copy link
Copy Markdown
Contributor

sruon commented Apr 20, 2025

Got CS to work after aligning all the NPC flags and models with the capture

@Xaver-DaRed
Copy link
Copy Markdown
Contributor

ampitere hasn't shown signs of life in quite a while. I assume this PR is abandoned, so I will close it.

@sruon Feel free to PR the battlefield if you got the CS working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants