[Magic] Implement elemental affinities and clean up elemental staves old mess#7443
Merged
Xaver-DaRed merged 2 commits intoLandSandBoat:basefrom Apr 18, 2025
Merged
Conversation
Prep work to code elemental affinities properly
579b182 to
d6a73e3
Compare
d6a73e3 to
1bce68c
Compare
4 tasks
zach2good
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
ELEMENTATTtoELEMENT_MABfor clarity.And all of this while lowering the overall number of lines.
Documentation:
https://www.bg-wiki.com/ffxi/Magic_Damage#Affinity
https://www.bg-wiki.com/ffxi/Category:Elemental_Staves
Steps to test these changes
Use magic with and without staves and have everything work equal to or better than before