Skip to content

[c++] [Combat] Split enspell damage bonus from weapons#7444

Merged
zach2good merged 1 commit intoLandSandBoat:basefrom
overefined:enspell_damage_weapons
Apr 19, 2025
Merged

[c++] [Combat] Split enspell damage bonus from weapons#7444
zach2good merged 1 commit intoLandSandBoat:basefrom
overefined:enspell_damage_weapons

Conversation

@overefined
Copy link
Copy Markdown
Contributor

@overefined overefined commented Apr 18, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Separates the enspell damage bonus gained from weapons and other items. Weapon enspell damage bonus now only applies to hits from the weapon that gives the bonus.

https://drive.google.com/file/d/1OSThzxK0cGA8IXy_DeQToUu7_KKscKlt/view?usp=sharing

Closes: #4815

Steps to test these changes

  1. change class to RDM/NIN
  2. !additem 16605
  3. !additem 17697
  4. cast enspell and attack something

@overefined overefined force-pushed the enspell_damage_weapons branch 3 times, most recently from bb9bc9d to 8a9cd5b Compare April 18, 2025 04:38
@Xaver-DaRed Xaver-DaRed changed the title Split enspell damage bonus [c++] [Combat] Split enspell damage bonus from weapons Apr 19, 2025
@zach2good zach2good merged commit 819cf9f into LandSandBoat:base Apr 19, 2025
13 checks passed
@overefined overefined deleted the enspell_damage_weapons branch April 19, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Enspell +Damage weapons affecting other weapons

3 participants