Skip to content

[core] Check for throwing weapons when calculating pDIF#7450

Merged
zach2good merged 1 commit intoLandSandBoat:basefrom
sruon:ranged_pdif
Apr 19, 2025
Merged

[core] Check for throwing weapons when calculating pDIF#7450
zach2good merged 1 commit intoLandSandBoat:basefrom
sruon:ranged_pdif

Conversation

@sruon
Copy link
Copy Markdown
Contributor

@sruon sruon commented Apr 19, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Checks the ammo slot for Throwing Weapons if no ranged weapon was found.
Without it, Shurikens (and other Throwing weapons) are defaulting to Marksmanship, leading to inaccurate calculations.

Also made it explicitely log should the "no weapons case" occur, instead of defaulting to Marksmanship.

Credits to JudgeMack, Deft, Sakiro, Integrity, Koca (@lumokai), MadMike (@madmikeblvd), Fabfury (and probably missed a few) for testing and providing steps to reproduce.

Steps to test these changes

!changejob NIN 99
!additem shuriken 99

Breakpoint and throw, see skill type used.

Co-Authored-By: lumokai <155067345+lumokai@users.noreply.github.com>
@zach2good zach2good merged commit 38a7b67 into LandSandBoat:base Apr 19, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants