[core] Check for throwing weapons when calculating pDIF#7450
Merged
zach2good merged 1 commit intoLandSandBoat:basefrom Apr 19, 2025
Merged
[core] Check for throwing weapons when calculating pDIF#7450zach2good merged 1 commit intoLandSandBoat:basefrom
zach2good merged 1 commit intoLandSandBoat:basefrom
Conversation
Xaver-DaRed
approved these changes
Apr 19, 2025
Co-Authored-By: lumokai <155067345+lumokai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Checks the ammo slot for Throwing Weapons if no ranged weapon was found.
Without it, Shurikens (and other Throwing weapons) are defaulting to Marksmanship, leading to inaccurate calculations.
Also made it explicitely log should the "no weapons case" occur, instead of defaulting to Marksmanship.
Credits to JudgeMack, Deft, Sakiro, Integrity, Koca (@lumokai), MadMike (@madmikeblvd), Fabfury (and probably missed a few) for testing and providing steps to reproduce.
Steps to test these changes
!changejob NIN 99
!additem shuriken 99
Breakpoint and throw, see skill type used.